Change in vdsm[master]: network: models: tag non-VDSM devices used by VDSM
danken at redhat.com
danken at redhat.com
Mon Mar 16 12:45:38 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
......................................................................
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/38572/4/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2377: {NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged': True,
Line 2378: 'vlan': VLAN_ID}}, {}, NOCHK)
Line 2379: self.assertEqual(status, SUCCESS, msg)
Line 2380: self.assertNetworkExists(NETWORK_NAME)
Line 2381: finally:
no need for such an empty finally clause.
Line 2382: pass
Line 2383:
Line 2384: self.vdsm_net.save_config()
Line 2385: self.vdsm_net.restoreNetConfig()
https://gerrit.ovirt.org/#/c/38572/4/vdsm/network/models.py
File vdsm/network/models.py:
Line 102: if (self.vlan and
Line 103: netinfo.operstate(self.name) == netinfo.OPERSTATE_UP and
Line 104: netinfo.ifaceUsed(self.name) and
Line 105: self.mtu <= netinfo.getMtu(self.name) and
Line 106: self.name in self.configurator.runningConfig.nics):
I don't think we have any problem with nics, and I don't think we have nics in the running config anyway.
Line 107: return
Line 108:
Line 109: self.configurator.configureNic(self, **opts)
Line 110:
Line 237: netinfo.operstate(self.name) == netinfo.OPERSTATE_UP and
Line 238: netinfo.ifaceUsed(self.name) and
Line 239: self.mtu <= netinfo.getMtu(self.name) and
Line 240: self.areOptionsApplied() and
Line 241: self.name in self.configurator.runningConfig.bonds and
this lookup is very cheap, and very much related to the condition of line 236. would you move it up?
Line 242: frozenset(slave.name for slave in self.slaves) ==
Line 243: frozenset(netinfo.slaves(self.name))):
Line 244: return
Line 245:
--
To view, visit https://gerrit.ovirt.org/38572
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list