Change in vdsm[ovirt-3.5]: init: fix network service status checking

ybronhei at redhat.com ybronhei at redhat.com
Mon Mar 16 12:38:42 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: init: fix network service status checking
......................................................................


init: fix network service status checking

In init file, we check if network service is running by its status
return code. Problem is, that this code is "always" 0, therefore we never
start network service when needed (for example, it's not autostarted
on CentOS 6).

`service network status` returns lists of configured and active devices,
if the list of active devices (on the last row) does not contains all
VDSM's ONBOOT=yes devices, it means, that network service did not start
our devices and we should call service network start.

Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38173
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Related-To: https://bugzilla.redhat.com/1194553
Reviewed-on: https://gerrit.ovirt.org/38369
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M init/sysvinit/vdsmd.init.in
1 file changed, 39 insertions(+), 2 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38369
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list