Change in vdsm[master]: stomp: Optimize stomp encoder\decoder

fromani at redhat.com fromani at redhat.com
Mon Mar 16 12:36:33 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: stomp: Optimize stomp encoder\decoder
......................................................................


Patch Set 8:

it is hard to review this patch.
Most of changes here leave me with a good gut feeling, but it's a leap of faith without proper rationale and possibly some numbers to prove the changes are indeed optimizations.

Moreover, I still have the feeling that this patch squashes together too many vaguely related changes.

-- 
To view, visit https://gerrit.ovirt.org/35255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list