Change in vdsm[master]: virt: factor out _getUnderlying* methods to another class.

fromani at redhat.com fromani at redhat.com
Mon Mar 16 11:03:06 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: factor out _getUnderlying* methods to another class.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38704/2//COMMIT_MSG
Commit Message:

Line 19: a. Add unit tests for this class.
Line 20: b. The technique in which getUnderlyingVmDevicesInfo changes the 'conf'
Line 21:    reference instead of returning data is cumbersome and hard to read. It
Line 22:    should return an updated copy of of the conf dictionary to the caller.
Line 23:    it will ease testing and debugging.
> IMO, this is the farthest we can change any bit of logic here without addin
The biggest problem of this approach is that we know as matter of fact that completing the move/split will take a while. A long while. Can even span across releases if things turn out bad. Until it is completed, we'll have to bear this intermediate step, which noone really likes.

Bearing that in mind, I believe the approach sketched here https://gerrit.ovirt.org/#/c/38402
- will allow us to meet everyone's goals
- it is bearable when interrupted (because will be interrupted), can be safely resumed
- allow us to add tests along the way.
Line 24: 
Line 25: Change-Id: Ia04b6ee17da207f772f77059e45be97594e6be78


-- 
To view, visit https://gerrit.ovirt.org/38704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04b6ee17da207f772f77059e45be97594e6be78
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list