Change in vdsm[master]: storage: Add multipath-resize command line tool

danken at redhat.com danken at redhat.com
Sun Mar 15 22:42:29 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: storage: Add multipath-resize command line tool
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/38467/5/vdsm/storage/multipath-resize
File vdsm/storage/multipath-resize:

Line 56: import logging
Line 57: import os
Line 58: import sys
Line 59: 
Line 60: from vdsm import concurrent
missing dependent patch?
Line 61: from vdsm import utils
Line 62: 
Line 63: MULTIPATHD = utils.CommandPath("multipathd",
Line 64:                                "/usr/sbin/multipathd",


Line 134: 
Line 135: 
Line 136: def resize_map(guid):
Line 137:     log.debug("Resizing map %s", guid)
Line 138:     cmd = [MULTIPATHD.cmd, "-k'resize map %s'" % guid]
we had seen Hebrew guids in the wild - better quote guid in case it has the single quote char.
Line 139:     start = utils.monotonic_time()
Line 140:     rc, out, err = utils.execCmd(cmd, raw=True, execCmdLogger=log)
Line 141:     if rc != 0:
Line 142:         raise Error("Resizing map %s failed: %s" % (guid, err))


-- 
To view, visit https://gerrit.ovirt.org/38467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I229ef55555fa757989329939a9267041785f2c0f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list