Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 15 15:09:29 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: Pop the frame even if a frame handler isn't defined
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/35940/7/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 439: 
Line 440:         frameHandler = self._frameHandler
Line 441:         while parser.pending > 0:
Line 442:             frame = parser.popFrame()
Line 443:             frameHandler.handle_frame(self, frame)
why not directly - 
 if parser.pending > 0
  self._frameHandler.handle_frame(self, parser.popFrame())
Line 444: 
Line 445:     def popFrame(self):
Line 446:         return self._parser.popFrame()
Line 447: 


-- 
To view, visit https://gerrit.ovirt.org/35940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list