Change in vdsm[master]: vdscli: allow a connection with a configurable timeout

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 15 14:30:12 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vdscli: allow a connection with a configurable timeout
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38751/1/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:

Line 241:         if port == 0:
Line 242:             port = None
Line 243:         self._setup(self._connection_class(host, port, key_file,
Line 244:                                            cert_file, strict,
Line 245:                                            timeout,
Please use timeout=timeout. timeout is an optional parameter so it must be called as such.

Same issue exists for host, port, key_file, cert_file, and strict, should be fixed in another patch.
Line 246:                                            ca_certs=ca_certs,
Line 247:                                            cert_reqs=cert_reqs))
Line 248: 
Line 249:         # we never actually use these for anything, but we keep them


-- 
To view, visit https://gerrit.ovirt.org/38751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list