Change in vdsm[master]: API: onlyUUID should affect only short status
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Fri Mar 13 09:19:20 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1378:
Line 1379: return dict(status=doneCode)
Line 1380:
Line 1381: # VM-related functions
Line 1382: def getVMList(self, fullStatus=False, vmList=(), onlyUUID=False):
Defaulting onlyUUID to False is bad idea for engines 3.5.0 which are not able to tell you what you want. This is way I decided to set it to True by default and modified all the places where we can make a choice.
Line 1383: """ return a list of known VMs with full (or partial) config each """
Line 1384: # To improve complexity, convert 'vms' to set(vms)
Line 1385: vmSet = set(vmList)
Line 1386: vmlist = [v.status(fullStatus)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 352: The VM object has no getInfo method. We use the method from 'Global' and
Line 353: pass arguments to get verbose information for only this one VM.
Line 354: """
Line 355: vmId = api._UUID
Line 356: return API.Global().getVMList(True, [vmId], False)
> strictly speaking, we don't *need* this change. Defaults should lead to cor
After adding check for fullStatus we indeed do not need this change.
Line 357:
Line 358:
Line 359: def VM_getInfo_Ret(ret):
Line 360: """
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list