Change in vdsm[master]: jsonrpc: add ability to get dictionary directly from JsonRpc...

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Mar 12 13:08:21 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpc: add ability to get dictionary directly from JsonRpcRequest
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/35254/7//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-11-18 00:53:56 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-03-12 11:40:09 +0100
Line 6: 
Line 7: jsonrpc: add ability to get dictionary directly from JsonRpcRequest
> I actually like the change, but why this is an improvement? is any piece of
I checked references to toDict() in 36368 which is high in patches stack and I do not see any other references to it except of the one introduced in this patch.

I believe that the author wanted to improve readiness of the code.
Line 8: 
Line 9: Change-Id: Ieb7edc48aa7d773b54db9d43e9f5460920e8ea50


-- 
To view, visit https://gerrit.ovirt.org/35254
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb7edc48aa7d773b54db9d43e9f5460920e8ea50
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list