Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Mar 12 08:09:21 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: asyncore: Move ssl buffer handling to dispatcher
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/37097/11/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 198:         self._messageHandler = msgHandler
Line 199:         self.check_read()
Line 200: 
Line 201:     def check_read(self):
Line 202:         if isinstance(self._socket, SSLSocket) and self._socket.pending() > 0:
> Shouldn't this use handle_read_event() too?
No. This is workaround for M2C not having socket.peek() which is used by protocol detection.
Line 203:             self._stompConn._dispatcher.handle_read()
Line 204: 
Line 205:     def send(self, message):
Line 206:         self.log.debug("Sending response")


-- 
To view, visit https://gerrit.ovirt.org/37097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list