Change in vdsm[master]: asyncore: Move generic reactor functionality
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon Mar 2 16:39:17 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/37055/6/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:
Line 364:
Line 365: def process_requests(self):
Line 366: self._isRunning = True
Line 367: while self._isRunning:
Line 368: asyncore.loop(use_poll=True, map=self._map, count=1, timeout=.5)
> Please reorder args (even when passing by name, life is easier when using t
Done
Line 369:
Line 370: for key, dispatcher in self._map.items():
Line 371: del self._map[key]
Line 372: dispatcher.close()
--
To view, visit https://gerrit.ovirt.org/37055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list