Change in vdsm[master]: stomp: parsing buffer refactoring
ybronhei at redhat.com
ybronhei at redhat.com
Sun Mar 15 09:20:08 UTC 2015
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
ok, so i have one comment
https://gerrit.ovirt.org/#/c/38666/2/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 159: self._flush()
Line 160:
Line 161: def _change_state(self, new_state):
Line 162: self._state = new_state
Line 163: self._state_cb = self._states[new_state]
please declare those attributes in init with default values
Line 164:
Line 165: def _flush(self):
Line 166: self._buffer = ""
Line 167:
--
To view, visit https://gerrit.ovirt.org/38666
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list