Change in vdsm[master]: net upgrade: log missing bonds

danken at redhat.com danken at redhat.com
Fri Mar 13 15:13:35 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net upgrade: log missing bonds
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38472/1/lib/vdsm/tool/unified_persistence.py
File lib/vdsm/tool/unified_persistence.py:

Line 161: readlines
> how about ending the search once both bond and onboot are set to true ?
yeah it could have been an acceptable optimization. However, this patch has been obsoleted by https://gerrit.ovirt.org/38587


-- 
To view, visit https://gerrit.ovirt.org/38472
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd4481d40cc25adb07c4e4ae7372357abc1a48a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list