Change in vdsm[master]: devices: move and rename getUnderlyingDeviceAddress
fromani at redhat.com
fromani at redhat.com
Fri Mar 13 14:31:42 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: devices: move and rename getUnderlyingDeviceAddress
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38714/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 506:
Line 507: xml.dom.minidom.Element.writexml = __hacked_writexml
Line 508:
Line 509:
Line 510: def get_device_address_from_xml(device_xml, index=0):
maybe we can drop the get_ prefix, but no big deal.
Line 511: """
Line 512: Obtain device's address from libvirt
Line 513: """
Line 514: address_xml = device_xml.getElementsByTagName('address')[index]
--
To view, visit https://gerrit.ovirt.org/38714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45fefb65461bcf97f75d607c55097eb5db2ed2ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list