Change in vdsm[master]: lvm: Allow autobackup option in lvm module

nsoffer at redhat.com nsoffer at redhat.com
Fri Mar 13 12:31:14 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: lvm: Allow autobackup option in lvm module
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/38195/7//COMMIT_MSG
Commit Message:

Line 14: Also currently most of the functions in lvm module accepts list
Line 15: of params in a tuple format and have some mandatory options.
Line 16: This may cause lvm call to fail if called with multiple
Line 17: conflicting options.
Line 18: 
What is missing is
- how this patch add the autobackup option
- known issues - you cannot call with both autobackup="y" and ("--autobackup", "y").
Line 19: Example: lvchange(vg, lvs, ('-autobackup', 'y'))
Line 20: Will fail with "Option -A/--autobackup may not be repeated" error.
Line 21: 
Line 22: Change-Id: I8190878fe071fad46800e666795b94779d745abf


-- 
To view, visit https://gerrit.ovirt.org/38195
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8190878fe071fad46800e666795b94779d745abf
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list