Change in vdsm[master]: monitor: return whether the reported status is actual

danken at redhat.com danken at redhat.com
Fri Mar 13 12:13:46 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: monitor: return whether the reported status is actual
......................................................................


monitor: return whether the reported status is actual

When the domain monitoring results are reported after the domain
monitor was started. The first monitoring run may haven't been yet
completed - which causes the returned status to be determined as OK
by the engine (leads to domain status change).

It was attempted to change the inital returned status in the past but it
broke the host activation flow in the engine (see change I8e0df) and
therefore the inital results can't be changed (backward comptability) -
therefore in this change i add a new info that indicates whether the
reported status is actual or not.

When providing the engine the information on whether the returned status
is actual or not, the engine can decide how to act upon the monitoring
result and ignore it if it's irrelevant.

Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d
Bug-Url: https://bugzilla.redhat.com/1183977
Signed-off-by: Liron Aravot <laravot at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/37952
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
M vdsm/storage/monitor.py
3 files changed, 14 insertions(+), 7 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/37952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list