Change in vdsm[master]: gluster: storage devices list provides device size in Mib

danken at redhat.com danken at redhat.com
Fri Mar 13 11:06:00 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: gluster: storage devices list provides device size in Mib
......................................................................


Patch Set 2:

(2 comments)

nits

https://gerrit.ovirt.org/#/c/38707/2//COMMIT_MSG
Commit Message:

Line 7: Mib
MiB,KiB,GiB: Bytes are written with upper case B.


https://gerrit.ovirt.org/#/c/38707/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 23: 
Line 24: 
Line 25: def _getDeviceDict(device, createBrick=False):
Line 26:     info = {'name': device.name,
Line 27:             'size': '',
it would be clearer to drop this line completely. No need to place 'size' and immediately override it.
Line 28:             'devPath': device.path,
Line 29:             'devUuid': device.uuid or '',
Line 30:             'bus': device.bus or '',
Line 31:             'model': '',


-- 
To view, visit https://gerrit.ovirt.org/38707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie56be6ff4e8ed5183f6c2111b007302473593361
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list