Change in vdsm[master]: API: onlyUUID should affect only short status

fromani at redhat.com fromani at redhat.com
Fri Mar 13 10:55:23 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: API: onlyUUID should affect only short status
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/38679/3//COMMIT_MSG
Commit Message:

Line 33: wit
> which
damn, missed in v4. Will fix.


https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:

Line 1388:                   if not vmSet or v.id in vmSet]
Line 1389:         if not fullStatus and onlyUUID:
Line 1390:             # BZ 1196735: api backward compatibility issue
Line 1391:             # REQUIRED_FOR: engine-3.5.0 only
Line 1392:             # REQUIRED_FOR: mom-0.4.3
> I think that if we update the spec and mom we do not need this patch at all
Agreed. Will keep up to date and address comments, but I'm prepared to abandon it anytime.
Line 1393:             vmlist = [v['vmId'] for v in vmlist]
Line 1394:         return {'status': doneCode, 'vmList': vmlist}
Line 1395: 
Line 1396:     def getExternalVMs(self, uri, username, password):


-- 
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list