Change in vdsm[master]: API: onlyUUID should affect only short status

fromani at redhat.com fromani at redhat.com
Fri Mar 13 08:34:13 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: API: onlyUUID should affect only short status
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38679/3/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 352:     The VM object has no getInfo method.  We use the method from 'Global' and
Line 353:     pass arguments to get verbose information for only this one VM.
Line 354:     """
Line 355:     vmId = api._UUID
Line 356:     return API.Global().getVMList(True, [vmId], False)
strictly speaking, we don't *need* this change. Defaults should lead to correct behaviour.

But given the story behind this bug, I'd rather have it.

Reviewers please share your thoughts.
Line 357: 
Line 358: 
Line 359: def VM_getInfo_Ret(ret):
Line 360:     """


-- 
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list