Change in vdsm[master]: network: persistence: skip bonds owned and used by vdsm

danken at redhat.com danken at redhat.com
Thu Mar 12 16:24:12 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: persistence: skip bonds owned and used by vdsm
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/38587/6/tests/unifiedPersistenceTests.py
File tests/unifiedPersistenceTests.py:

Line 127: 
Line 128: 
Line 129: @contextmanager
Line 130: def _fake_ifcfgs():
Line 131:     temp_dir = tempfile.mkdtemp()
Please use a tool that we already have

 with testrunner.namedTemporaryDir() as temp_dir:
Line 132:     try:
Line 133:         for iface, conf in FAKE_IFCFGS.iteritems():
Line 134:             with open(os.path.join(temp_dir, 'ifcfg-' + iface), 'w') as f:
Line 135:                 f.write(conf)


-- 
To view, visit https://gerrit.ovirt.org/38587
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb643a0c3681631db7bd875a03ebdb91fd893e70
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list