Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.

ibarkan at redhat.com ibarkan at redhat.com
Thu Mar 12 13:26:21 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................


Patch Set 12:

(3 comments)

https://gerrit.ovirt.org/#/c/38249/12/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 23: from . import hwclass
Line 24: 
Line 25: 
Line 26: class HostDevice(core.Base):
Line 27:     __slots__ = ('address', 'bootOrder', '_deviceParams', 'macAddr', 'vlanId')
> Since vlanId is kept in specParams, why propagate it to the object itself?
It is just a convenient way to communicate state. otherwise I would have to repeat myself.
Line 28: 
Line 29:     def __init__(self, conf, log, **kwargs):
Line 30:         super(HostDevice, self).__init__(conf, log, **kwargs)
Line 31: 


Line 30:         super(HostDevice, self).__init__(conf, log, **kwargs)
Line 31: 
Line 32:         self._deviceParams = get_device_params(self.device)
Line 33: 
Line 34:         self.macAddr = self.specParams.get('macAddr')
> There is a bit of inconsistence between HostDevice and NIC: macAddr in NIC 
not sure I am following you.
Line 35:         self.vlanId = self.specParams.get('vlanid')
Line 36: 
Line 37:     def detach(self):
Line 38:         """


Line 31: 
Line 32:         self._deviceParams = get_device_params(self.device)
Line 33: 
Line 34:         self.macAddr = self.specParams.get('macAddr')
Line 35:         self.vlanId = self.specParams.get('vlanid')
> On the other hand, vlanId is ok within specParams, just minor typo (i->I): 
done
Line 36: 
Line 37:     def detach(self):
Line 38:         """
Line 39:         Detach the device from the host. This method *must* be


-- 
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list