Change in vdsm[master]: virt: Do not count time spent on migrationCreate against tim...

danken at redhat.com danken at redhat.com
Thu Mar 12 12:04:38 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: Do not count time spent on migrationCreate against timeout
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/38397/5/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 275:         except Exception as e:
Line 276:             self._recover(str(e))
Line 277:             self.log.exception("Failed to migrate")
Line 278: 
Line 279:     def _startUnderlyingMigration(self, startTime):
> come to think of it, now nothing make any use of the startTime argument. We
(12:02:21 PM) fromani: danken: we do want to take into account the time spent on source in hooks. We don't want to take into account the time spent on destination in preparing things. Hence the logic evilissimo added
Line 280:         if self.hibernating:
Line 281:             hooks.before_vm_hibernate(self._vm._dom.XMLDesc(0), self._vm.conf)
Line 282:             try:
Line 283:                 self._vm._vmStats.pause()


-- 
To view, visit https://gerrit.ovirt.org/38397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafdaa13136757d455e405328173aa3243bea3995
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list