Change in vdsm[master]: virt: Do not count time spent on migrationCreate against tim...

ykaplan at redhat.com ykaplan at redhat.com
Thu Mar 12 09:44:46 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: virt: Do not count time spent on migrationCreate against timeout
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/38397/4/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 302: destinationCreateStartTime
To be compatible with next variable 'destCreationTime':

s/destinationCreateStartTime/ destCreateStartTime


Line 300:             # destination. In some cases some expensive operations can cause
Line 301:             # the migration to get cancelled right after the transfer started.
Line 302:             destinationCreateStartTime = time.time()
Line 303:             response = self.destServer.migrationCreate(self._machineParams)
Line 304:             # Adds the time spent on migrationCreate to the startTime
This comment is redundant, 
code should be self explanatory.
Line 305:             destCreationTime = time.time() - destinationCreateStartTime
Line 306:             startTime += destCreationTime
Line 307:             self.log.info('Creation of destination VM took: %d seconds',
Line 308:                           time.time() - destinationCreateStartTime)


Line 304:             # Adds the time spent on migrationCreate to the startTime
Line 305:             destCreationTime = time.time() - destinationCreateStartTime
Line 306:             startTime += destCreationTime
Line 307:             self.log.info('Creation of destination VM took: %d seconds',
Line 308:                           time.time() - destinationCreateStartTime)
s/ time.time() - destinationCreateStartTime/ destCreationTime
Line 309: 
Line 310:             if response['status']['code']:
Line 311:                 self.status = response
Line 312:                 raise RuntimeError('migration destination error: ' +


-- 
To view, visit https://gerrit.ovirt.org/38397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafdaa13136757d455e405328173aa3243bea3995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list