Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.

dnarayan at redhat.com dnarayan at redhat.com
Thu Mar 12 09:23:50 UTC 2015


Darshan N has posted comments on this change.

Change subject: gluster: Adds new verbs to setup gluster geo-replication.
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/38228/5/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 99: GlusterGeoRepPublicKeyWriteFailedException
> No 'e' available here
Done


Line 116: raise
> You haven't taken the rsa/dsa keys in the comparison.  The above thing woul
The sample of single public key generated by geo-rep is as follows:

'command="tar ${SSH_ORIGINAL_COMMAND#* }"  ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDTTE3or6J8/hMcveaaou8FedMQNBjkjGB+PxCiiQ5VSahi7Ah0SYKpk70BNYlaRb+XNkfkqoeP+bHXLWUpKH1k2Sl7eVqDeJQhy7QRndz3nnVAOITupyQ0BIRlqX+7AxSAAtqV9DQQ7jQi8Fz3JROxRahSQqKMmR/PUDhUN/EpWSJ7Doh9yA4gAta5Db2hePmE6HzEns/aS2AOO2cBKQvURv9/Rx1ktrCkazWjuPtF5NX85U7eaBtc0hsgfkmPnwzOMvxKdPS6ApNywNBzRosjjJb2ZfaYRsmVQXWZad7xEMUnpxT5id17e++E7Lni5l8yOMu4bYcHpXjluSWi+FUl root at dhcp43-63.lab.eng.blr.redhat.com\n'

They have the ssh set up for selected commands, so the key contains command as well. Because of this I was taking the whole key(command,rsa-key,user at host) to compare. some keys in the authorized_keys file(user copied keys) might not have the command part in the key, so for the comparison to be unambiguous, I feel its better to compare the whole key.

Please provide your thoughts.


-- 
To view, visit https://gerrit.ovirt.org/38228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list