Change in vdsm[master]: gluster: add createBrick verb

tjeyasin at redhat.com tjeyasin at redhat.com
Thu Mar 12 09:21:23 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 23:

(1 comment)

https://gerrit.ovirt.org/#/c/35498/23/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:

Line 80: 
Line 81:     def storageDevicesList(self, options=None):
Line 82:         return self._gluster.storageDevicesList()
Line 83: 
Line 84:     def createBrick(self, name, mountPoint, devList, fsType, raidParams={}):
> In schema you marked fsType as optional. I do not see default value here. P
Done
Line 85:         return self._gluster.createBrick(name, mountPoint,
Line 86:                                          devList, fsType, raidParams)
Line 87: 
Line 88: 


-- 
To view, visit https://gerrit.ovirt.org/35498
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list