Change in vdsm[master]: network: persistence: skip bonds owned and used by vdsm
danken at redhat.com
danken at redhat.com
Wed Mar 11 16:07:27 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38587/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-03-11 15:58:06 +0100
Line 4: Commit: Petr Horáček <phoracek at redhat.com>
Line 5: CommitDate: 2015-03-11 16:16:11 +0100
Line 6:
Line 7: network: persistence: skip bonds owned and used by vdsm
Please add some meat to this message (and Bug-Url).
When upgrading bonds to unified persistence, we should skip foreign bond (a bond that has ifcfg-bond lacking the "generated by vdsm" header). However, if any of these bonds is used by a vdsm network, it must be persisted. Otherwise, calling restore_net removes the bond (when it cleans current running config) but it fails to re-create it from the persistent config.
Line 8:
Line 9: Change-Id: Idb643a0c3681631db7bd875a03ebdb91fd893e70
https://gerrit.ovirt.org/#/c/38587/2/lib/vdsm/tool/unified_persistence.py
File lib/vdsm/tool/unified_persistence.py:
Line 139: for network, attributes in networks.iteritems():
Line 140: if attributes.get('bonding') not in bonds:
Line 141: raise Exception('Network %s miss its bonds', network)
Line 142:
Line 143: return _processNetworks(netinfo), _processBondings(netinfo)
why are you calling the _process functions again?
Line 144:
Line 145:
Line 146: def _persist(networks, bondings):
Line 147: runningConfig = RunningConfig()
--
To view, visit https://gerrit.ovirt.org/38587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb643a0c3681631db7bd875a03ebdb91fd893e70
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list