Change in vdsm[master]: storage: Remove validateStorageServerConnection

alitke at redhat.com alitke at redhat.com
Wed Mar 11 13:49:01 UTC 2015


Adam Litke has posted comments on this change.

Change subject: storage: Remove validateStorageServerConnection
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Looks good but you forgot to remove something in the schema.  See comment.

https://gerrit.ovirt.org/#/c/38230/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 5958
Line 5959
Line 5960
Line 5961
Line 5962
StorageServerConnectionValidateStatus is now an orphaned type.  You should remove its definition as well.


-- 
To view, visit https://gerrit.ovirt.org/38230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c0f3678005c4075098f134a628fef1f3fc8e612
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list