Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.

dnarayan at redhat.com dnarayan at redhat.com
Wed Mar 11 12:53:23 UTC 2015


Darshan N has posted comments on this change.

Change subject: gluster: Adds new verbs to setup gluster geo-replication.
......................................................................


Patch Set 4:

(10 comments)

https://gerrit.ovirt.org/#/c/38228/4/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 76: GlusterGeoRepPublicKeyFileNotFoundException
> you need to pass err=[str(e)]
Done


Line 85:  
> have 
Done


Line 87: GlusterGeoRepUserNotFoundException
> you should pass [str(e)]
Done


Line 93: sshDir
> 1. call os.makedirs() only if it doesn't exist
Done


Line 98: raise
> You should handle the exception and raise proper gluster exception.
Done


Line 105: authKeys
> you should do this once you have written things successfully
Done


Line 106: key
> Why can't geoRepPubKeys be list of strings?  If you prefer this way, you sh
Done


Line 107: pubKeys
> You should match token[1] of pubkeys.splitlines() and geoRepPubKeys.splitli
Done


Line 108: write
> You should use safeWrite().
Done


Line 111: GlusterGeoRepPublicKeyWriteFailedException
> err=[str(e)]
Done


-- 
To view, visit https://gerrit.ovirt.org/38228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list