Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 11 10:58:03 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

Still missing is support for reading/creating libvirt address (which could also be generalized for those devices)

https://gerrit.ovirt.org/#/c/38249/9/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 126:         source.appendChildWithArgs('address', type=type,
Line 127:                                    **self._deviceParams['address'])
Line 128: 
Line 129:     def _get_spec_param(self, spec_params, key):
Line 130:         return spec_params.get(key) if spec_params is not None else None
in Base device:
self.specParams = {}
(afaik) this helper is not needed since you can do self.specParams.get()


-- 
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list