Change in vdsm[master]: hostdev: display hostdev passthrough support in caps

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 11 10:52:16 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: display hostdev passthrough support in caps
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/37701/5/vdsm/caps.py
File vdsm/caps.py:

Line 691:         caps['liveSnapshot'] = str(liveSnapSupported).lower()
Line 692:     caps['liveMerge'] = str(getLiveMergeSupport()).lower()
Line 693:     caps['kdumpStatus'] = _getKdumpStatus()
Line 694: 
Line 695:     caps['hostdevPassthrough'] = str(_getHostdevPassthorughSupport()).lower()
> I just don't know if this rename addresses Dan's comment in v4.
It's a bit different approach overall, because I've done additional testing and realized that the presence of dmar0 indicates vt-d/amd-vi ^ iommu enabled. Therefore, no 2 separate keywords should exist and we only have one - is the passthrough gonna work or not.
Line 696: 
Line 697:     return caps
Line 698: 
Line 699: 


-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list