Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Wed Mar 11 08:05:36 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/37509/9/vdsm/v2v.py
File vdsm/v2v.py:

Line 179:         self._vmProperties = vmProperties
Line 180:         self._job_id = jobId
Line 181:         self._cif = cif
Line 182:         self._status = _STATUS_INITIALIZING
Line 183:         self._progress = 0
> This is not a good name - the user expect this to be the ImportVm progress,
it was supposed to be the overall progress. The job is the complete conversion consisting of multiple disks
Line 184:         self._abort = False
Line 185:         self._status_msg = ''
Line 186: 
Line 187:     def start(self):


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list