Change in vdsm[master]: Move NUMA collecting code to stats thread

danken at redhat.com danken at redhat.com
Tue Mar 10 22:49:12 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Move NUMA collecting code to stats thread
......................................................................


Move NUMA collecting code to stats thread

NUMA collecting was performed any time the .get() method was
invoked. That caused a serious slow down. This patch moves
the collecting to where all the other stats are collected.

I measured the performance of getAllVmStats before and after
this patch was applied on a host with local storage and
two NUMA enabled VMs using:

# time for x in $(seq 100); do
#   vdsClient -s 0 getAllVmStats >/dev/null;
# done

The results for unpatched VDSM:

real	0m21.093s
user	0m11.998s
sys	0m1.690s

The results for patched VDSM:

real	0m18.485s
user	0m12.009s
sys	0m1.846s

And the results for both patched and unpatched VDSM when no
NUMA enabled VM is started are very similar:

real	0m18.298s
user	0m11.878s
sys	0m1.699s

Change-Id: I3fff147d892ecbe7e01629a6c9428f911672fcdd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182094
Signed-off-by: Martin Sivak <msivak at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/36906
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/config.py.in
M vdsm/virt/vm.py
2 files changed, 17 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Martin Sivák: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/36906
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fff147d892ecbe7e01629a6c9428f911672fcdd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list