Change in vdsm[master]: clusterLock: Make inquire retval consistent

nsoffer at redhat.com nsoffer at redhat.com
Tue Mar 10 19:35:56 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: clusterLock: Make inquire retval consistent
......................................................................


Patch Set 1: Code-Review+1

I think we should raise something instead of returning expected output (2-tuple) with unexpected values (None), but making it consistent is obviously better then the current situation.

-- 
To view, visit https://gerrit.ovirt.org/38552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b9227773e44d48b21aa4eaba7c7fe1ab599931
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list