Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.

ibarkan at redhat.com ibarkan at redhat.com
Tue Mar 10 15:18:58 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................


Patch Set 7:

(2 comments)

version 8 fixed a few bugs and version 9 added support for vlan and boot order and addressed the code review comments

https://gerrit.ovirt.org/#/c/38249/7/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 107:         interface = self.createXmlElem(hwclass.NIC, hwclass.HOSTDEV)
Line 108:         interface.setAttrs(managed='no')
Line 109:         interface.appendChildWithArgs('driver', name='vfio')
Line 110:         source = interface.appendChildWithArgs('source')
Line 111:         source.appendChildWithArgs('address', **self._deviceParams['address'])
> +1 for bootOrder
I recon  interface does support it, as "many devices do", but libvirt generates it automatically so we can just ignore it.
boot order creation was factored out also.
Line 112:         interface.appendChildWithArgs('mac', address=self.macAddr)
Line 113: 


Line 107:         interface = self.createXmlElem(hwclass.NIC, hwclass.HOSTDEV)
Line 108:         interface.setAttrs(managed='no')
Line 109:         interface.appendChildWithArgs('driver', name='vfio')
Line 110:         source = interface.appendChildWithArgs('source')
Line 111:         source.appendChildWithArgs('address', **self._deviceParams['address'])
> I suspect that bootOrder should be added here as well.
Done
Line 112:         interface.appendChildWithArgs('mac', address=self.macAddr)
Line 113: 


-- 
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list