Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

ybronhei at redhat.com ybronhei at redhat.com
Tue Mar 10 13:37:02 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

please try and see if proc.blocking helps to remove the sleep

https://gerrit.ovirt.org/#/c/37509/8/vdsm/v2v.py
File vdsm/v2v.py:

Line 262:                                     % line)
Line 263:                     break
Line 264:                 self._handle_progress(proc, line)
Line 265:             # readline() is none blocking call so we want to sleep 100ms
Line 266:             time.sleep(0.1)
but now when you use execCmd the return value is AsyncProc which you can set - proc.blocking=True and its stdout.readline should block and the sleep can move
Line 267: 
Line 268:     def _handle_progress(self, proc, line):
Line 269:         re_progress = re.compile(r'\s+\((\d+).*')
Line 270:         while not self._abort:


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list