Change in vdsm[master]: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _g...

danken at redhat.com danken at redhat.com
Tue Mar 10 13:09:42 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _getIfaceConfValues
......................................................................


ifcfg: stop reading from NetDevice.ipConfig namedtuple in _getIfaceConfValues

_getIfaceConfValues updates a copy of a NetDevice's IP configuration before
actually configuring it. The changes must not be brought back to the original
IpConfig so deep copy is performed.

The namedtuple is still returned by _getIfaceConfValues (for now) but in
the next patch the copied IpConfig will be returned directly.

ipconfig.bootproto is not compared against None for compatibility reasons
(it could contain a zero-length string, for instance). It will be converted
to a boolean 'dhcpv4' soon.

Change-Id: Ic72f387b45023527d14a17ba1b44b04d620243e2
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/37793
Reviewed-by: Petr Horáček <phoracek at redhat.com>
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 20 insertions(+), 20 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Ondřej Svoboda: Verified
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/37793
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic72f387b45023527d14a17ba1b44b04d620243e2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list