Change in vdsm[master]: vm: stats: cache metadata value

danken at redhat.com danken at redhat.com
Tue Mar 10 11:59:45 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: stats: cache metadata value
......................................................................


vm: stats: cache metadata value

vcpuLimit can be set only by Engine (or anyone else
impersonating it using the UpdateVmPolicy API).

It seems a little wasteful to poll, albeit infrequently
(every 15s), for changes in a value which we know
when and how it will change.

Instead of doing so, this patch adds a simple cache
variable, to be transparently updated after
each UpdateVmPolicy.

Please note that the same approach was taken for I/O
tune, based on the assumption that VDSM is the only
controller of libvirt.

Since this assumption is ingrained in the very roots
of how VDSM works, it seem fair to extend to (V)CPU
tune as well.

Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/37592
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 38 insertions(+), 48 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/37592
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list