Change in vdsm[ovirt-3.5]: qemu-img: check/use "-T src_cache" option in convert/rebase ...

ybronhei at redhat.com ybronhei at redhat.com
Tue Mar 10 08:53:57 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: qemu-img: check/use "-T src_cache" option in convert/rebase when available
......................................................................


qemu-img: check/use "-T src_cache" option in convert/rebase when available

"qemu-img" is used for operations like disk move or snapshot delete.
This process reads data using the hypervisor page cache. As this data might
be hotter than any VM memory the system starts swapping out memory pages of
the running VMs.

vdsm already uses "-t none" option to avoid cache for output image. Now
"qemu-img" introduced a new "-T src_cache" to avoid cache for the
input image (bz#1116558).

This patch is testing if qemu-img has the new "-T src_cache" option available
for convert and rebase commands and using it with "-T none" when true.

Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1199141
Signed-off-by: Amador Pahim <apahim at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36308
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38434
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/vdsm/qemuimg.py
1 file changed, 29 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Amador Pahim: Verified
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list