Change in vdsm[master]: sdm: Allow query of task information on SDM hosts

danken at redhat.com danken at redhat.com
Mon Mar 9 23:10:46 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: sdm: Allow query of task information on SDM hosts
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/38096/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 2187:     def getAllTasksStatuses(self, spUUID=None, options=None):
Line 2188:         """
Line 2189:         Gets the status of all public tasks.
Line 2190: 
Line 2191:         :param spUUID: The UUID of the storage pool that you
this text is now completely out of date
Line 2192:                        want to check it's tasks.
Line 2193:         :type spUUID: UUID (deprecated)
Line 2194:         :options: ?
Line 2195:         """


Line 2193:         :type spUUID: UUID (deprecated)
Line 2194:         :options: ?
Line 2195:         """
Line 2196:         # getSharedLock(tasksResource...)
Line 2197:         if spUUID == volume.BLANK_UUID:
naming: as spUUID is never used to carry a UUID of a storage pool (and it would never would), I suggest to give it a fresh name (poolOnly=False? sdm=True?) and a relevant type (boolean).

The new arg should be documented in the schema, whatever its name is.
Line 2198:             allTasksStatus = self.taskMng.getAllTasksStatuses('sdm')
Line 2199:         else:
Line 2200:             try:
Line 2201:                 sp = self.pools.values()[0]


-- 
To view, visit https://gerrit.ovirt.org/38096
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77ada3dc2707bca0198dac87a1e87a48bd4a9b1c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list