Change in vdsm[master]: models: rename NetDevice.ip to ipconfig to be more descriptive

osvoboda at redhat.com osvoboda at redhat.com
Mon Mar 9 21:33:16 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: models: rename NetDevice.ip to ipconfig to be more descriptive
......................................................................


Patch Set 7:

Excuse me for being brief this time but the new Gerrit ate my poor message, I must have hit some "clever" keyboard shortcut or something :-(

iproute2 configurator also hasn't broken, as I tested on Fedora 21.

Tests that failed both on master and with the whole topic applied:

testBrokenNetworkReplacement
testReconfigureBrNetWithVanishedPort
testSetupNetworksAddDelDhcp (bridged)
testSetupNetworksDoesNotDeleteTheBridge
testSetupNetworksReconfigureBridge

On master, now, I was not even able to have some other tests succeed but with the patch set only those above failed which shows that the patches are good enough and I should be able to shift my focus back on IPv6 and/or fixing of iproute2/pyroute2 configurators.

-- 
To view, visit https://gerrit.ovirt.org/37797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3aae9ec5cd0bb8eea6022935f1836a1a44bf848
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list