Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
danken at redhat.com
danken at redhat.com
Mon Mar 9 17:28:27 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/38249/7/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 107: interface = self.createXmlElem(hwclass.NIC, hwclass.HOSTDEV)
Line 108: interface.setAttrs(managed='no')
Line 109: interface.appendChildWithArgs('driver', name='vfio')
Line 110: source = interface.appendChildWithArgs('source')
Line 111: source.appendChildWithArgs('address', **self._deviceParams['address'])
I suspect that bootOrder should be added here as well.
Why do you take 'address' from somewhere else than where _create_generic_hostdev_xml() takes it?
I suspect that these two elements can be created in a single place for both functions.
Line 112: interface.appendChildWithArgs('mac', address=self.macAddr)
Line 113:
--
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list