Change in vdsm[master]: RFE: Report downtime for each live migration

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Mar 9 13:39:54 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: RFE: Report downtime for each live migration
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/37075/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3056:             if 'downtime' in stat:
Line 3057:                 self._actualDowntime = stat['downtime']
Line 3058:             else:
Line 3059:                 self._actualDowntime = None
Line 3060:         except Exception as e:
> we must not swallow all exceptions - you should swallow only a specific exc
"If this is the case, I'd rather not even ask libvirt, as periodic libvirt calls are known to accumulate and become expensive."
it's one per VM migration destination finish, that's not that bad...SLA does worse things...
Line 3061:             self.log.error('error fetching domains jobStats: %r', e.message)
Line 3062: 
Line 3063:     def _waitForUnderlyingMigration(self):
Line 3064:         timeout = config.getint('vars', 'migration_destination_timeout')


-- 
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list