Change in vdsm[master]: storage: introducing vdsm-dump-chains script

ybronhei at redhat.com ybronhei at redhat.com
Mon Mar 9 13:05:29 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/38281/7/client/vdsm-dump-chains.in
File client/vdsm-dump-chains.in:

Line 3: CLIENT="@VDSMDIR@/vdsm_dump_chains.py"
Line 4: [ -e "$CLIENT" ] || CLIENT="$CLIENT"c
Line 5: 
Line 6: [ -n "$PYTHONPATH" ] && PYTHON_FORMATTED_PATH=":$PYTHONPATH"
Line 7: PYTHONPATH="@VDSMDIR@$PYTHON_FORMATTED_PATH" python "$CLIENT" "$@"
> or, we can simply place the new python module here.
no. how is it related to vdsm client? either part vdsm-tool or under storage or be part of vdsm api and run it with vdsClient.

it sounds and looks like helper utility, I don't see any reason to not include it as vdsm-tool verb.


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list