Change in vdsm[master]: vm: abort vm start if can't read pid

danken at redhat.com danken at redhat.com
Mon Mar 9 12:28:27 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: abort vm start if can't read pid
......................................................................


vm: abort vm start if can't read pid

If for whatever (quite unlikely) cause
the PID can't be read, or it is invalid,
abort the creation of the VM.

In recovery flow, we should'nt overwrite the PID,
because there is no reason to believe it changed
meantime - and most likely, it has not.

Change-Id: I1b80baba14caded2fb3ef74451498751347323ea
Bug-Url: https://bugzilla.redhat.com/1128458
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/36129
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
M tests/vmfakelib.py
M vdsm/virt/vm.py
3 files changed, 46 insertions(+), 9 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/36129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b80baba14caded2fb3ef74451498751347323ea
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list