Change in vdsm[master]: vm: abort vm start if can't read pid
fromani at redhat.com
fromani at redhat.com
Mon Mar 9 12:03:35 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/36129/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4355: self.log.error('cannot read pid')
Line 4356: raise
Line 4357: else:
Line 4358: if pid <= 0:
Line 4359: raise ValueError('read invalid pid: %i', pid)
> %i is not going to be used to format the string - please replace the coma w
Done
Line 4360: return pid
Line 4361:
Line 4362: def _updateDomainDescriptor(self):
Line 4363: domainXML = self._dom.XMLDesc(0)
--
To view, visit https://gerrit.ovirt.org/36129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b80baba14caded2fb3ef74451498751347323ea
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list