Change in vdsm[master]: api: use recommended logging
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Mon Mar 9 10:42:28 UTC 2015
Michal Skrivanek has posted comments on this change.
Change subject: api: use recommended logging
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38422/1/vdsm/API.py
File vdsm/API.py:
Line 1368: level: requested logging level. `logging.DEBUG` `logging.ERROR`
Line 1369:
Line 1370: Doesn't survive a restart
Line 1371: """
Line 1372: logging.info('Setting loglevel to %s', level)
this should imho be higher prio as you want to see the change when setting WARN and CRIT
Line 1373: handlers = logging.getLogger().handlers
Line 1374: [fileHandler] = [h for h in handlers if
Line 1375: isinstance(h, logging.FileHandler)]
Line 1376: fileHandler.setLevel(int(level))
--
To view, visit https://gerrit.ovirt.org/38422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c3b4aa3344b5093d13fb11e017394cf0bf52b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list