Change in vdsm[master]: network: api: raise error on removal of assigned bond

danken at redhat.com danken at redhat.com
Mon Mar 9 10:17:38 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: api: raise error on removal of assigned bond
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/37883/2/vdsm/network/errors.py
File vdsm/network/errors.py:

Line 28: ERR_BAD_BRIDGE = 27
Line 29: ERR_USED_BRIDGE = 28
Line 30: ERR_FAILED_IFUP = 29
Line 31: ERR_FAILED_IFDOWN = 30
Line 32: ERR_USED_BOND = 31
Please change the comment in define.py properly (let's use 21-35).
Line 33: ERR_LOST_CONNECTION = 10    # noConPeer
Line 34: 
Line 35: 
Line 36: class ConfigNetworkError(Exception):


-- 
To view, visit https://gerrit.ovirt.org/37883
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46edad27b27b96a8d04c04f01b2d5f3e465eb417
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list