Change in vdsm[master]: executor: avoid to notify() busy workers

fromani at redhat.com fromani at redhat.com
Fri Mar 6 19:43:30 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: executor: avoid to notify() busy workers
......................................................................


Patch Set 3:

(4 comments)

sorry for late answer

https://gerrit.ovirt.org/#/c/37326/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-01-23 13:35:29 +0100
Line 4: Commit:     Francesco Romani <fromani at redhat.com>
Line 5: CommitDate: 2015-02-02 12:55:18 +0100
Line 6: 
Line 7: executor: avoid to notify() busy workers
> avoid to notify() busy workers -> avoid notifying if no workers are waiting
will change
Line 8: 
Line 9: Optimize the usage of Condition variable in
Line 10: the TaskQueue class.
Line 11: 


Line 17: 
Line 18: Profiling suggests that to notify() already busy
Line 19: Workers is wasteful and drags down performance,
Line 20: due to the need to acquire the underlying Condition
Line 21: variable.
> Lets cut down the bullshit and show profiling results of real world usage.
Will just run simulations again and include hard data in the next submission
Line 22: 
Line 23: Thus, this patch avoids notify()cation if there are
Line 24: not Workers waiting for tasks, to achieve better
Line 25: performances.


Line 19: Workers is wasteful and drags down performance,
Line 20: due to the need to acquire the underlying Condition
Line 21: variable.
Line 22: 
Line 23: Thus, this patch avoids notify()cation if there are
> I think a less smart text like "avoids notification" will be more clear :-)
fair enough, will change
Line 24: not Workers waiting for tasks, to achieve better
Line 25: performances.
Line 26: 
Line 27: Credits for profiling and original optimization to


Line 20: due to the need to acquire the underlying Condition
Line 21: variable.
Line 22: 
Line 23: Thus, this patch avoids notify()cation if there are
Line 24: not Workers waiting for tasks, to achieve better
> not Workers -> no workers
will change
Line 25: performances.
Line 26: 
Line 27: Credits for profiling and original optimization to
Line 28: Nir Soffer during the review of the Executor patch


-- 
To view, visit https://gerrit.ovirt.org/37326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia197ee8bdeea3e1a353fc9fa5953788d95d53581
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list