Change in vdsm[master]: api: introducing onlyUUID parameter for getVMList verb

danken at redhat.com danken at redhat.com
Fri Mar 6 17:23:09 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: api: introducing onlyUUID parameter for getVMList verb
......................................................................


api: introducing onlyUUID parameter for getVMList verb

Due to vdsm sending only an array of vmids in a response to getVMList
the engine asks separately using VM.getStats which creates unnecessary
load. In order to fix this issue we introduce a new parameter 'onlyUUID'
which is set to True by default. Engine 3.5.0 still wants to get an
array of vmids, but for all other versions we set 'onlyUUID' to False
which returns map of vmids and statuses.


Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-Url: https://bugzilla.redhat.com/1196735
Related-To: https://gerrit.ovirt.org/#/c/38448
Reviewed-on: https://gerrit.ovirt.org/38449
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
4 files changed, 20 insertions(+), 18 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list