Change in vdsm[master]: api: introducing short parameter for getVMList verb

fromani at redhat.com fromani at redhat.com
Fri Mar 6 12:35:30 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: api: introducing short parameter for getVMList verb
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38449/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3605: # @fullStatus:  #optional When set to False return limited info
Line 3606: #
Line 3607: # @vmList:      #optional Filter the results by a list of UUIDs
Line 3608: #
Line 3609: # @short:       #optional determines whether we need short of full status
> It would be more noble to define VmInfo as
+1 Dan's suggestion here also address my comment below
Line 3610: #
Line 3611: # Returns:
Line 3612: # A list of VmInfos
Line 3613: #


-- 
To view, visit https://gerrit.ovirt.org/38449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9eb359f6995c09d61a3159e733498fa3b55780
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list